feat(cluster): add proxmox_virtual_environment_metrics_server
resource
#1719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor's Note
/docs
for any user-facing features or additions./fwprovider/tests
for any new or updated resources / data sources.make example
to verify that the change works as expected.Proof of Work
Hi, this adds new metrics server resource and datasource to the provider. With somewhat improved language skills after PRs in last year, i think I probably got everything right more than less. It is opinionated to prefix graphite and influxdb specific variables in resource but leave it as-is in API client, but felt right to me.
Take your time for that... I got examples and acc tests working fine to help make it happen as much as possible.
PS. Seems Proxmox folks made not-broken-and-weird API responses this time for metrics server, which means
boolean
in docs is either1
or0
hence I usedint64
in client, usually it requiredtypes.CustomBool
since there were strings"1"
or"0"
if I remember correctly 😃Community Note
Closes #0000 | Relates #0000