Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cluster): add proxmox_virtual_environment_metrics_server resource #1719

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

rafsaf
Copy link
Contributor

@rafsaf rafsaf commented Jan 19, 2025

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Hi, this adds new metrics server resource and datasource to the provider. With somewhat improved language skills after PRs in last year, i think I probably got everything right more than less. It is opinionated to prefix graphite and influxdb specific variables in resource but leave it as-is in API client, but felt right to me.

Take your time for that... I got examples and acc tests working fine to help make it happen as much as possible.

PS. Seems Proxmox folks made not-broken-and-weird API responses this time for metrics server, which means boolean in docs is either 1 or 0 hence I used int64 in client, usually it required types.CustomBool since there were strings "1" or "0" if I remember correctly 😃

image

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #0000 | Relates #0000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant