Apply suggestions from code review

again add pits suggestions Co-authored-by: Pit Buttchereit <[email protected]>
bptlab · May 24, 2024 · 35b0441 · 35b0441
1 parent c227dfb
commit 35b0441
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/tracex_project/extraction/logic/modules/module_metrics_analyzer.py b/tracex_project/extraction/logic/modules/module_metrics_analyzer.py
@@ -92,7 +92,7 @@ def __rate_activity_relevance(activity: str, condition: str | None) -> str:
         return category
 
     def __rate_timestamps_correctness(
-        self, activity: str, start, end
+        self, activity: str, start: pd.DateTime, end: pd.DateTime
     ) -> Tuple[str, float]:
         messages = Prompt.objects.get(name="METRIC_TIMESTAMP_MESSAGES").text
         messages.append(

diff --git a/tracex_project/extraction/logic/modules/module_time_extractor.py b/tracex_project/extraction/logic/modules/module_time_extractor.py
@@ -100,20 +100,20 @@ def __calculate_duration(row: pd.Series) -> str:
     def __post_processing(df: pd.DataFrame) -> pd.DataFrame:
         """Fill missing values for dates with default values."""
 
-        def convert_to_datetime(df: pd.DataFrame, column: pd.Series):
+        def convert_to_datetime(df: pd.DataFrame, column: pd.Series) -> pd.DataFrame:
             df[column] = pd.to_datetime(
                 df[column], format="%Y%m%dT%H%M", errors="coerce"
             )
 
             return df
 
-        def set_default_date_if_na(df: pd.DataFrame, column: pd.Series):
+        def set_default_date_if_na(df: pd.DataFrame, column: pd.Series) -> pd.DataFrame:
             if df[column].isna().all():
                 df[column] = df[column].fillna(pd.Timestamp("2020-01-01 00:00"))
 
             return df
 
-        def fill_missing_values(df: pd.DataFrame, column: pd.Series):
+        def fill_missing_values(df: pd.DataFrame, column: pd.Series) -> pd.DataFrame:
             df[column] = df[column].ffill().bfill()
 
             return df

diff --git a/tracex_project/extraction/logic/orchestrator.py b/tracex_project/extraction/logic/orchestrator.py
@@ -120,7 +120,7 @@ def get_configuration(self):
         """Return the configuration for the orchestrator instance."""
         return self.configuration
 
-    def set_data(self, data: pd.DataFrame):
+    def set_data(self, data: pd.DataFrame) -> None:
         """Set the data for the orchestrator instance."""
         self.data = data