Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/130 cohort ontology #132

Merged
merged 15 commits into from
May 27, 2024
Merged

Feature/130 cohort ontology #132

merged 15 commits into from
May 27, 2024

Conversation

tkv29
Copy link
Collaborator

@tkv29 tkv29 commented May 17, 2024

In this PR the SNOMED CT API is being requested in order to normalize the condition and preconditions.
The SNOMED CT term and conceptId will be saved. The conceptId is the unique identifier of a concept in SNOMED CT. For future work it would be useful to save this in the db.

@tkv29 tkv29 requested review from FR-SON and PitButtchereit May 17, 2024 09:01
@tkv29 tkv29 self-assigned this May 17, 2024
@PitButtchereit PitButtchereit linked an issue May 17, 2024 that may be closed by this pull request
Copy link
Collaborator

@PitButtchereit PitButtchereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes/explanations for clarification needed. Also I encountered an error while trying to execute the pipeline. I've posted the traceback below. Please have a look into this.

Bildschirmfoto 2024-05-17 um 11 47 26

tracex_project/tracex/logic/utils.py Outdated Show resolved Hide resolved
tracex_project/tracex/logic/utils.py Outdated Show resolved Hide resolved
@tkv29
Copy link
Collaborator Author

tkv29 commented May 17, 2024

Now I'm checking if items exists and catching with that bad request if they occur, so the pipeline will not be interrupted
image

Copy link
Collaborator

@PitButtchereit PitButtchereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lezz go! Still, the cohort tagger extracts the wrong conditions, but this is an issue with the prompts.

@tkv29 tkv29 requested review from thangixd and removed request for FR-SON May 21, 2024 12:37
@nils-schmitt nils-schmitt merged commit 127c998 into main May 27, 2024
2 checks passed
@nils-schmitt nils-schmitt deleted the feature/130-cohort-ontology branch May 27, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cohort ontology normalization
4 participants