Refactor/134 code check Trace Testing Environment #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor/comparator.py
…aceTestingResultView` into smaller pieces
|
could you please drop the metrics in the view after the extraction for the trace testing env and in the trace testing env result view 
|
thangixd
reviewed
May 24, 2024
|
the code looks fine to me gj! |
thangixd
approved these changes
May 24, 2024
# Conflicts: # tracex_project/db.sqlite3 # tracex_project/extraction/fixtures/prompts_fixture.json # tracex_project/extraction/logic/orchestrator.py
nils-schmitt
requested changes
May 24, 2024
tracex_project/trace_comparator/templates/testing_comparison.html
Outdated
Show resolved
Hide resolved
nils-schmitt
requested changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements refactoring for the trace_comparator app. The following changes were made:
This closes #134