Use most generic UART functions #42

brainelectronics · 2022-12-28T09:54:15Z

Baudrate specific inter frame time is used at Modbus RTU internal function _uart_read of serial.py instead of constant value of 5ms

ESP32 port specific wait_tx_done function replaced by generic wait time calculation in _send function of serial.py, see 'UART' object has no attribute 'wait_tx_done' #34
A 1ms delay has been added between turning the RS485 control pin on and sending the Modbus PDU in _send function of serial.py

…ime calculation in serial.py, resolve #34

…e Modbus RTU PDU, related to #34

…f serial.py, related to #34

brainelectronics

LGTMyself
Waiting for final feedback from @beyonlo

beyonlo · 2022-12-29T19:31:30Z

LGTMyself Waiting for final feedback from @beyonlo

@brainelectronics everything works OK - excellent!

Here are the results done with this PR.

I really appreciate it

brainelectronics added 4 commits December 28, 2022 10:48

replace ESP32 port specific wait_tx_done function with generic wait t…

7077951

…ime calculation in serial.py, resolve #34

wait for 1ms after turning Modbus RTU control pin high and sending th…

c1e6fd5

…e Modbus RTU PDU, related to #34

use baudrate specific inter frame sleep time in _uart_read function o…

9381746

…f serial.py, related to #34

update changelog with fix and improvements for #34

c36d586

brainelectronics added the bug Something isn't working label Dec 28, 2022

brainelectronics self-assigned this Dec 28, 2022

brainelectronics linked an issue Dec 28, 2022 that may be closed by this pull request

'UART' object has no attribute 'wait_tx_done' #34

Closed

use proper time sleep function in serial _uart_read function

b43e5db

brainelectronics commented Dec 29, 2022

View reviewed changes

brainelectronics merged commit ebb8258 into develop Dec 29, 2022

brainelectronics deleted the bugfix/use-most-generic-uart-functions branch December 29, 2022 19:40

Provide feedback