Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20170512 c friendly #4

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

prozacchiwawa
Copy link

Some trivial changes:

  • Ensure that the code only does id() on objects that are allocated, confirming that all other slice copies are temporary, and that no address is used in tree construction that isn't the result of an allocation.
  • Rename _ref and _deref to _deref and _addrof to make more sense in context. _ref would make sense if this was an operation with a ref counting side effect, but here it's used to retrieve the object pointed to by a pointer. _deref here retrieves a pointer to an allocated object.
  • Rename flip_* to set_* for clarity.

What do you think about this?

@bramcohen
Copy link
Owner

I did a big update today which got rid of all the flip_* stuff. Not sure about the id() validation stuff, I think a lot of that is covered by the tests. Not sure about the _ref names and don't want to mess with them at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants