-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewards 3.0 android #26945
base: master
Are you sure you want to change the base?
Rewards 3.0 android #26945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
586d756
to
57a7131
Compare
ffa5e43
to
e0a1e45
Compare
e0a1e45
to
dcc5aea
Compare
ba637da
to
19caaef
Compare
Chromium major version is behind target branch (132.0.6834.111 vs 133.0.6943.27). Please rebase. |
19caaef
to
449ef11
Compare
2dfc44b
to
6d3daac
Compare
android/java/org/chromium/chrome/browser/rewards/RewardsCustomTabRootUiCoordinator.java
Outdated
Show resolved
Hide resolved
7b78ff4
to
3308bd2
Compare
Chromium major version is behind target branch (133.0.6943.98 vs 134.0.6998.15). Please rebase. |
3308bd2
to
3180f07
Compare
3180f07
to
6a7eb6b
Compare
[puLL-Merge] - brave/brave-core@26945 DescriptionThis PR introduces a new full-screen custom tab activity for displaying Brave Rewards pages on Android. It includes feature flags for enabling a new Rewards UI and additions to handle publisher information more comprehensively. The changes primarily focus on creating a better user experience for interacting with Brave Rewards. ChangesChanges
sequenceDiagram
participant User
participant ToolbarLayout
participant RewardsHelper
participant CustomTab
participant NativeWorker
User->>ToolbarLayout: Clicks rewards button
ToolbarLayout->>RewardsHelper: shouldShowNewRewardsUI()
alt New UI Enabled
RewardsHelper-->>ToolbarLayout: true
ToolbarLayout->>CustomTab: showRewardsPage()
CustomTab->>User: Displays full-screen rewards
else Legacy UI
RewardsHelper-->>ToolbarLayout: false
ToolbarLayout->>User: Shows rewards popup
end
NativeWorker->>ToolbarLayout: onFrontTabPublisherChanged
ToolbarLayout->>ToolbarLayout: updateVerifiedPublisherMark
|
Update entry points for rewards with rewards 3.0 flag
…ards 3.0 changes in custom tab
…press Update close button position on the page
Remove logs Add null check Remove changes for backpress
Encode Url for creators
Add native function to open url into rewards_page_ui
Remove comments and refactor changes
Resolve rebase error
6a7eb6b
to
12d8347
Compare
Resolves brave/brave-browser#38434
Resolves brave/brave-browser#42273
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: