-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused BraveFederatedService #27658
Conversation
b179ae3
to
e933bed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
and DEPS
++
86a52a2
to
f39c21a
Compare
[puLL-Merge] - brave/brave-core@27658 DescriptionThis PR removes the ChangesChangesBy filename:
The sequence diagram shows how the federated learning system previously operated with data collection and remote server communication, which is now being removed entirely from the codebase. sequenceDiagram
participant Browser
participant FederatedService
participant DataStore
participant RemoteServer
Note over Browser,RemoteServer: Previous Implementation
Browser->>FederatedService: Initialize
FederatedService->>DataStore: Create storage
Browser->>FederatedService: Start collection
FederatedService->>DataStore: Store training data
FederatedService->>RemoteServer: Send collection pings
FederatedService->>RemoteServer: Send delete ping on shutdown
Note over Browser,RemoteServer: After PR
Browser->>Browser: Federated learning functionality removed
Possible Issues
Security Hotspots
|
Since this service was always behind a disabled feature flag I left out any cleanup of the prefs/db file |
Released in v1.77.44 |
Resolves brave/brave-browser#44005
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: