Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds wasm32-unknown-unknown and rust-lld #27660

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

szilardszaloki
Copy link
Collaborator

Resolves brave/brave-browser#42613.
DevOps issue: https://github.com/brave/devops/issues/12869.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@szilardszaloki szilardszaloki requested review from a team as code owners February 14, 2025 02:30
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) needs-security-review labels Feb 14, 2025
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json changes 👍

build/commands/scripts/commands.js Outdated Show resolved Hide resolved
script/build_rust_toolchain_aux.py Outdated Show resolved Hide resolved
script/build_rust_toolchain_aux.py Outdated Show resolved Hide resolved
script/build_rust_toolchain_aux.py Outdated Show resolved Hide resolved
script/build_rust_toolchain_aux.py Outdated Show resolved Hide resolved
@szilardszaloki szilardszaloki force-pushed the szilard/42613-wasm32-unknown-unknown-rust-lld branch from bd64650 to 26b6f8a Compare February 15, 2025 00:45
@szilardszaloki szilardszaloki force-pushed the szilard/42613-wasm32-unknown-unknown-rust-lld branch from 26b6f8a to cb9516e Compare February 15, 2025 00:46
Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

build/rust/build_rust_toolchain_aux.py Show resolved Hide resolved
@szilardszaloki
Copy link
Collaborator Author

SonarCloud is complaining about the TAR file in the PR: Make sure that expanding this archive file is safe here. — false positive, as the .tar.xz is being constructed (not extracted).

@szilardszaloki szilardszaloki merged commit 748bed8 into master Feb 17, 2025
17 of 18 checks passed
@szilardszaloki szilardszaloki deleted the szilard/42613-wasm32-unknown-unknown-rust-lld branch February 17, 2025 17:28
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 17, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wasm32-unknown-unknown to the Rust toolchain.
6 participants