Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf tests: Fix downloading WPR during rebase #27670

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

atuchin-m
Copy link
Collaborator

@atuchin-m atuchin-m commented Feb 14, 2025

Resolves brave/brave-browser#44070

We use chrome://components page now. The telemetry code considers chrome:// pages as local, so WPR isn't downloaded despite the page is in the list.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@atuchin-m atuchin-m changed the title perf tests: xix downloading WPR during rebase perf tests: Fix downloading WPR during rebase Feb 14, 2025
@atuchin-m atuchin-m force-pushed the perf-test-fix-downloading-wpr-for-rebase branch from ff91b3e to 2b0427c Compare February 14, 2025 15:53
Copy link
Contributor

Chromium major version is behind target branch (133.0.6943.54 vs 134.0.6998.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@atuchin-m atuchin-m force-pushed the perf-test-fix-downloading-wpr-for-rebase branch from 2b0427c to eff7172 Compare February 18, 2025 18:31
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@atuchin-m atuchin-m marked this pull request as ready for review February 18, 2025 18:31
@atuchin-m atuchin-m requested a review from a team as a code owner February 18, 2025 18:31
@atuchin-m atuchin-m enabled auto-merge (squash) February 20, 2025 15:19
@atuchin-m atuchin-m merged commit 970dc2f into master Feb 20, 2025
18 of 20 checks passed
@atuchin-m atuchin-m deleted the perf-test-fix-downloading-wpr-for-rebase branch February 20, 2025 16:01
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 20, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Perf infra] WPR file isn't always downloaded for brave_utils.UpdateProfile
3 participants