Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change reported attributes for onboarding and default browser metrics #27683

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

DJAndries
Copy link
Collaborator

Resolves brave/brave-browser#44016

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@DJAndries DJAndries marked this pull request as ready for review February 15, 2025 04:04
@DJAndries DJAndries requested a review from a team as a code owner February 15, 2025 04:04
Copy link
Contributor

Chromium major version is behind target branch (133.0.6943.54 vs 134.0.6998.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@DJAndries DJAndries force-pushed the onboarding-retention-p3a branch from b3925a6 to 1e61cc2 Compare February 19, 2025 02:07
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 19, 2025
@DJAndries DJAndries enabled auto-merge February 19, 2025 02:37
@DJAndries DJAndries merged commit 4c5950d into master Feb 19, 2025
18 checks passed
@DJAndries DJAndries deleted the onboarding-retention-p3a branch February 19, 2025 05:56
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 19, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change attributes for onboarding screen and default browser metrics
3 participants