-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): prevent empty coingecko ids while querying prices #27685
Merged
+22
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ Wallet Front-end
nuo-xu
requested changes
Feb 17, 2025
ios/brave-ios/Sources/BraveWallet/Extensions/AssetRatioServiceExtensions.swift
Show resolved
Hide resolved
ios/brave-ios/Sources/BraveWallet/Extensions/AssetRatioServiceExtensions.swift
Outdated
Show resolved
Hide resolved
aff67b5
to
e5529a8
Compare
nuo-xu
approved these changes
Feb 17, 2025
c57f5b3
to
772def3
Compare
772def3
to
0c222e1
Compare
Chromium major version is behind target branch (133.0.6943.98 vs 134.0.6998.15). Please rebase. |
Douglashdaniel
approved these changes
Feb 18, 2025
0c222e1
to
dc8cd5b
Compare
brave-builds
added a commit
that referenced
this pull request
Feb 19, 2025
brave-builds
added a commit
that referenced
this pull request
Feb 19, 2025
7 tasks
7 tasks
Released in v1.77.52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#44020
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
N/A