Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): prevent empty coingecko ids while querying prices #27685

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

onyb
Copy link
Member

@onyb onyb commented Feb 15, 2025

Resolves brave/brave-browser#44020

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

N/A

@onyb onyb self-assigned this Feb 15, 2025
@onyb onyb requested review from a team as code owners February 15, 2025 07:25
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Feb 15, 2025
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Wallet Front-end

@onyb onyb force-pushed the f/wallet/empty-ratio-calls branch from aff67b5 to e5529a8 Compare February 17, 2025 18:49
@onyb onyb requested a review from nuo-xu February 17, 2025 18:49
@onyb onyb enabled auto-merge (squash) February 17, 2025 18:51
@onyb onyb force-pushed the f/wallet/empty-ratio-calls branch from c57f5b3 to 772def3 Compare February 18, 2025 13:55
@onyb onyb disabled auto-merge February 18, 2025 14:03
@onyb onyb force-pushed the f/wallet/empty-ratio-calls branch from 772def3 to 0c222e1 Compare February 18, 2025 14:10
@onyb onyb enabled auto-merge (squash) February 18, 2025 14:59
Copy link
Contributor

Chromium major version is behind target branch (133.0.6943.98 vs 134.0.6998.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@onyb onyb force-pushed the f/wallet/empty-ratio-calls branch from 0c222e1 to dc8cd5b Compare February 18, 2025 20:13
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Feb 18, 2025
@onyb onyb merged commit 9925e3b into master Feb 19, 2025
18 checks passed
@onyb onyb deleted the f/wallet/empty-ratio-calls branch February 19, 2025 09:14
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 19, 2025
brave-builds added a commit that referenced this pull request Feb 19, 2025
brave-builds added a commit that referenced this pull request Feb 19, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid hitting Ratios service with empty coingecko ids
4 participants