Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeHealth][rust] parking_lot_core 0.9.7 => 0.9.10 #27722

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

cdesouza-chromium
Copy link
Collaborator

This PR updates this crate to a newer version, which occasions the dropping of one duplicated crate, namely, windows-sys v0.45.0, as the newer parking_lot_core can rely on windows-sys v0.52.0.

Resolves brave/brave-browser#44088

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@cdesouza-chromium cdesouza-chromium self-assigned this Feb 19, 2025
@cdesouza-chromium cdesouza-chromium requested review from a team and bridiver as code owners February 19, 2025 05:20
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) puLL-Merge labels Feb 19, 2025
This PR updates this crate to a newer version, which occasions the
dropping of one duplicated crate, namely, `windows-sys v0.45.0`, as the
newer `parking_lot_core` can rely on `windows-sys v0.52.0`.

Resolves brave/brave-browser#44088
@cdesouza-chromium cdesouza-chromium force-pushed the update-to-parking-lot-core-0.9.10 branch from 9974544 to 6348a0d Compare February 19, 2025 13:25
Copy link
Contributor

[puLL-Merge] - brave/brave-core@27722

Description

This PR updates several Rust dependencies in the Brave Core repository, specifically:

  1. Downgrading parking_lot_core from v0.9.10 to v0.9.7
  2. Downgrading redox_syscall from v0.5.8 to v0.2.16
  3. Adding windows-sys v0.45.0

The changes appear to be part of dependency management and version alignment efforts.

Changes

Changes

  1. parking_lot_core:

    • Moved from v0.9.10 to v0.9.7
    • All files moved to new version directory with no content changes
  2. redox_syscall:

    • Downgraded from v0.5.8 to v0.2.16
    • Files moved to new version directory
  3. windows-sys:

    • Added new dependency v0.45.0
    • Added complete module structure for Windows API bindings
    • Added BUILD.gn and README.chromium files
sequenceDiagram
    participant Brave as Brave Core
    participant PLC as parking_lot_core
    participant RS as redox_syscall
    participant WS as windows-sys
    
    Note over Brave: Dependency Update
    Brave->>PLC: Downgrade to v0.9.7
    Brave->>RS: Downgrade to v0.2.16
    Brave->>WS: Add v0.45.0
    Note over WS: New Windows API bindings
Loading

@bridiver bridiver merged commit 57cbc9c into master Feb 19, 2025
18 checks passed
@bridiver bridiver deleted the update-to-parking-lot-core-0.9.10 branch February 19, 2025 17:59
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 19, 2025
kdenhartog pushed a commit that referenced this pull request Feb 19, 2025
This PR updates this crate to a newer version, which occasions the
dropping of one duplicated crate, namely, `windows-sys v0.45.0`, as the
newer `parking_lot_core` can rely on `windows-sys v0.52.0`.

Resolves brave/brave-browser#44088
@brave-builds
Copy link
Collaborator

Released in v1.77.54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update parking_lot_core to get rid of windows-sys v0.45.0
3 participants