Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use chromium code for idna crate #27899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

use chromium code for idna crate #27899

wants to merge 1 commit into from
+284 −94,931

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Mar 1, 2025 •
edited
Loading

@bridiver bridiver requested a review from a team as a code owner March 1, 2025 02:18
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Mar 1, 2025
@bridiver bridiver requested a review from a team as a code owner March 1, 2025 04:07
@bridiver bridiver force-pushed the stub-idna-crate branch 2 times, most recently from 4c38035 to 73ce44a Compare March 1, 2025 13:09
@bridiver bridiver changed the title use chromium idna code fof rust use chromium code for idna crate Mar 1, 2025
@bridiver bridiver force-pushed the stub-idna-crate branch 2 times, most recently from 97217e7 to 99e1500 Compare March 1, 2025 17:57
@bridiver bridiver force-pushed the stub-idna-crate branch 2 times, most recently from c50c02f to 4be8db2 Compare March 1, 2025 18:03
Base automatically changed from stub-url-crate to master March 3, 2025 22:51
DJAndries
DJAndries reviewed Mar 3, 2025
View reviewed changes
third_party/rust/idna/v0_2/crate/src/lib.rs

#[derive(Default)]
pub struct Errors {
punycode: bool,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these fields can be removed if unused. the fields in the original type are private anyway

DJAndries
DJAndries reviewed Mar 4, 2025
View reviewed changes
third_party/rust/idna/v0_2/crate/src/lib.rs
@@ -0,0 +1,178 @@
// Copyright 2016 The rust-url developers.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to keep this copyright notice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJAndries DJAndries DJAndries left review comments

@iefremov iefremov iefremov approved these changes

@antonok-edm antonok-edm antonok-edm approved these changes

Assignees

@bridiver bridiver

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bridiver @iefremov @DJAndries @antonok-edm