Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/raid button #45

Merged
merged 5 commits into from
Mar 19, 2022

Conversation

joaom00
Copy link
Member

@joaom00 joaom00 commented Mar 16, 2022

This PR adds raid button to copy raid command to clipboard.

Demo

raid.mp4

Closes #24

@NandoSangenetto
Copy link
Member

image

The button is too close to the text. Do you think it is possible to increase the space between them?

@NandoSangenetto
Copy link
Member

Adding @brunobandev as a reviewer to check this design change.

Btw, it is a nice feature. That is going to be useful.

Ps: Make sure to fix the test :D

@joaom00
Copy link
Member Author

joaom00 commented Mar 16, 2022

The test is passing on my machine. I don't know what could have happened to have failed.

Copy link
Contributor

@brunobandev brunobandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joaom00 well done, it'll be very useful mainly for other streamers.

@joaom00
Copy link
Member Author

joaom00 commented Mar 16, 2022

Thanks! @brunobandev

@NandoSangenetto
Copy link
Member

NandoSangenetto commented Mar 17, 2022

The test is passing on my machine. I don't know what could have happened to have failed.

I'm going to try it here tomorrow.

@NandoSangenetto
Copy link
Member

@joaom00 It is a flaky test. It will work most of the time testing using the Cypress' graphic interface (yarn open) but it will always fail when using the CLI (yarn cy:run).

I could find some workarounds, take a look:

@NandoSangenetto
Copy link
Member

Also, I was thinking here.

The raid button is not something that most users will use. It is going to be used by streamers. It would be nice if the user could set the website as "streamer mode." It could be a toggle button.

@joaom00
Copy link
Member Author

joaom00 commented Mar 19, 2022

@NandoSangenetto All tests are passing!!

@joaom00
Copy link
Member Author

joaom00 commented Mar 19, 2022

Also, I was thinking here.

The raid button is not something that most users will use. It is going to be used by streamers. It would be nice if the user could set the website as "streamer mode." It could be a toggle button.

Would it make sense to do this just for the raid button? I think it would make sense if we had more features for streamers. This would fit in with what @brunobandev suggested #23

@NandoSangenetto NandoSangenetto merged commit 233ec14 into brdevstreamers:main Mar 19, 2022
@NandoSangenetto
Copy link
Member

NandoSangenetto commented Mar 19, 2022

Also, I was thinking here.
The raid button is not something that most users will use. It is going to be used by streamers. It would be nice if the user could set the website as "streamer mode." It could be a toggle button.

Would it make sense to do this just for the raid button? I think it would make sense if we had more features for streamers. This would fit in with what @brunobandev suggested #23

Yeah, we can discuss that later.

@joaom00 joaom00 deleted the feature/raid-button branch March 20, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create button to copy a command to raid channels
3 participants