-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/raid button #45
Feature/raid button #45
Conversation
Adding @brunobandev as a reviewer to check this design change. Btw, it is a nice feature. That is going to be useful. Ps: Make sure to fix the test :D |
The test is passing on my machine. I don't know what could have happened to have failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joaom00 well done, it'll be very useful mainly for other streamers.
Thanks! @brunobandev |
I'm going to try it here tomorrow. |
@joaom00 It is a flaky test. It will work most of the time testing using the Cypress' graphic interface ( I could find some workarounds, take a look: |
Also, I was thinking here. The raid button is not something that most users will use. It is going to be used by streamers. It would be nice if the user could set the website as "streamer mode." It could be a toggle button. |
@NandoSangenetto All tests are passing!! |
Would it make sense to do this just for the raid button? I think it would make sense if we had more features for streamers. This would fit in with what @brunobandev suggested #23 |
Yeah, we can discuss that later. |
This PR adds raid button to copy raid command to clipboard.
Demo
raid.mp4
Closes #24