Stores sidebar #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added all the stores in a sidebar panel. The panel is mobile friendly and will either take 25% of the width of the page or 100% for devices with smaller screens. TODO: - Hook selection / deselection to the form; - Hook buttons to the form; - Remove the previous implementation;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the store filter for a sidebar component. Stores can be selected and deselected individually - users will also be able to select / deselect all stores.
I believe the implementation for this feature is finished but I can think of two possible improvements (let me know if you want them implemented before merging this pull request):