migration to ODS 4.0

[breznak]

Fixes #17

[breznak]

@JohnnyMarek I have managed to resolve the blockers, so we can now update to ODS 4.0 ! (which may be faster for the maps, also uses (still BETA!) jMEv3.1)

Please push all your code (even if non-working) today, so I can test compatibility with this new 4.0 version and merge.

[breznak]

getting this crash :(

Říj 13, 2016 11:20:08 ODP. com.jme3.app.LegacyApplication handleError
SEVERE: Uncaught exception thrown in Thread[jME3 Main,5,main]
java.lang.NullPointerException
    at com.jme3.niftygui.InputSystemJme.handleMouseEvent(InputSystemJme.java:123)
    at com.jme3.niftygui.InputSystemJme.onMouseButtonEventQueued(InputSystemJme.java:231)
    at com.jme3.niftygui.InputSystemJme.forwardEvents(InputSystemJme.java:295)
    at de.lessvoid.nifty.Nifty.update(Nifty.java:363)
    at com.jme3.niftygui.InputSystemJme.endInput(InputSystemJme.java:112)
    at com.jme3.input.InputManager.processQueue(InputManager.java:843)
    at com.jme3.input.InputManager.update(InputManager.java:907)
    at com.jme3.app.LegacyApplication.update(LegacyApplication.java:725)
    at com.jme3.app.SimpleApplication.update(SimpleApplication.java:227)
    at com.jme3.system.lwjgl.LwjglAbstractDisplay.runLoop(LwjglAbstractDisplay.java:151)
    at com.jme3.system.lwjgl.LwjglDisplay.runLoop(LwjglDisplay.java:193)
    at com.jme3.system.lwjgl.LwjglAbstractDisplay.run(LwjglAbstractDisplay.java:232)
    at java.lang.Thread.run(Thread.java:745)

[breznak]

@JohnnyMarek I found a very similar problem, but I don't understand their solution, can you take a look later please?
https://hub.jmonkeyengine.org/t/cant-interact-with-the-gui-because-nifty-is-null/35156/22

[JohnnyMarek]

does it occur all the time after start or some special cases?

[breznak]

Only in our scenario!
(So I suspect the GUI controller you override must be updated again to match the version in ODS 4.

[JohnnyMarek]

what branch should i download to look at it? ods4_migration? Will try to fix it. I guess i have an idea where is the mistake

[breznak]

Yes, this one, ods4_migration. I think it happens on our MenuScreen. It looks like the game even runs a little, then the menu opens, game pauses, ..I can set all stuff..then after Start it crashes.

What I found is that Screen screen = nifty.getCurrentScreen(); can be null. Ok, it's in instructionScreenGui (and this one does not fix it), so it must be in our override pakage.

[breznak]

Btw, the game appears much faster with v4, hope it will be also case for our scenario!

[breznak]

@JohnnyMarek ok, there will be the bug !
To make this fix future-proof, please don't make DistractionScreenGUIController a copy of ScreenGUIController, instead, make it extends from it and override only the needed parts

[JohnnyMarek]

Thanks! this analysis helps a lot. I am 80% positive i will be able to fix it soon. If not now, later in the morning :) and yes, that's the problem, i will put all our code to our package cvut. :) thanks for the input. Hope the game will be faster too :P but for that i am preparing other fix with partially works but that's for later... Won't be able to make it for the conference i am affriad.

[breznak]

Thanks!

that's the problem, i will put all our code to our package cvut

actually, this code is from our package, but we had to modify the ScreenGUIController (for some reason?), so it has to be updated.

I'm looking forward to know more about the planned optimizations 👏

Btw, please address the comments in #48 so I can merge it tomorrow and try to apply my cleanups from the other PR.