-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SrLatnMeTest.php #2743
base: master
Are you sure you want to change the base?
Update SrLatnMeTest.php #2743
Conversation
Thanks. 🙏 Hello @milose @Glavic, invoking Serbian contributors 🧙 here to have a second look and if you can, please proceed the relevant changes on: |
Looks good to me @kylekatarnls, thanks @perisicnikola37 |
Carbon/src/Carbon/Lang/sr_Latn_ME.php Line 60 in 1e60d1b
return '[prošlog ponedjeljka u] LT'; |
@kylekatarnls Why this is still not merged? |
Hello @perisicnikola37 this is only a test file, that does not actually change the actual translations which live in:
So if I merge this alone, actually test won't pass anymore and it will have no effect for users. It would need now to change accordingly all language files and tests (if there are other countries that ME that are concerned). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source files need to be updated accordingly:
https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Lang/sr.php
I have another issue, I don't know why I cannot run the tests on this PR, maybe it needs to be rebased on last changes of master branch. |
No description provided.