Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SrLatnMeTest.php #2743

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

perisicnikola37
Copy link
Contributor

No description provided.

@kylekatarnls
Copy link
Collaborator

Thanks. 🙏

Hello @milose @Glavic, invoking Serbian contributors 🧙 here to have a second look and if you can, please proceed the relevant changes on:
https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Lang/sr_Latn_ME.php

@kylekatarnls kylekatarnls added the translation Rely to internationalization label Jan 1, 2023
@milose
Copy link
Contributor

milose commented Jan 2, 2023

Looks good to me @kylekatarnls, thanks @perisicnikola37

@milose
Copy link
Contributor

milose commented Jan 2, 2023

return '[prošle nedjelje u] LT';
should be changed as per test to:

return '[prošlog ponedjeljka u] LT';

@perisicnikola37
Copy link
Contributor Author

@kylekatarnls Why this is still not merged?

@kylekatarnls
Copy link
Collaborator

Hello @perisicnikola37 this is only a test file, that does not actually change the actual translations which live in:
https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Lang/sr.php

  • the variants Cyrl and Latn

So if I merge this alone, actually test won't pass anymore and it will have no effect for users.

It would need now to change accordingly all language files and tests (if there are other countries that ME that are concerned).

Copy link
Collaborator

@kylekatarnls kylekatarnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylekatarnls
Copy link
Collaborator

I have another issue, I don't know why I cannot run the tests on this PR, maybe it needs to be rebased on last changes of master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Rely to internationalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants