This repository has been archived by the owner on Dec 17, 2018. It is now read-only.
mouseTime fix #33
Open
mouseTime fix #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the mouseTime, which is currently sometimes wrong. With the current video.js default skin, there is an offset in time due to the volume control sometimes taking the space. The code I'm using is taken from the core of video.js:
https://github.com/videojs/video.js/pull/2569/files#diff-be82dd77ef994b77f1636de6ed9d2c59R45
https://github.com/videojs/video.js/blob/master/src/js/utils/dom.js#L473