Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

PallHaraldsson
Copy link

[skip ci]

[skip ci]
@PallHaraldsson
Copy link
Author

PallHaraldsson commented Apr 16, 2022

I'm mostly curious what's the point of this package, since there are other available, at least one faster, and some with more "bells and whistles".

(@v1.6) pkg> add https://github.com/kescobo/ArgParseLite.jl

julia> @time using ArgParseLite
  0.001742 seconds (2.50 k allocations: 229.547 KiB)

[EDIT, I'm pretty sure I got the above timing, and nr. of allocations, before, even though I now have a hard time replicating, and rather get:]

julia> @time using ArgParseLite
  0.002481 seconds (5.12 k allocations: 460.219 KiB)

julia> @time using QuickArgParse
  0.002049 seconds (2.65 k allocations: 258.039 KiB)

julia> @time using DocOpt
  0.003732 seconds (4.73 k allocations: 394.562 KiB)

julia> @time using ArgParse
  0.004584 seconds (8.02 k allocations: 743.281 KiB)

Note, it got faster in version 1.1.2: carlobaldassi/ArgParse.jl#104

You could use the same trick, but it seems it wouldn't be effective.

Your other package PlasmaCNA didn't work for me, even with QuickArgParse installed (and I can see you want it registered, just to be able to add it as a dependency). I'm not going to interfere with you registrating the package (for now), but is the need for it based on a misunderstanding? I like fast startup (of script), and options! But too many packages to choose from can be confusing (there are more, at least ArgParse2.jl).

julia> @time using PlasmaCNA
[ Info: Precompiling PlasmaCNA [acf0aa16-7d9c-11ea-1c55-b9a94f4bac42]
ERROR: LoadError: LoadError: UndefVarError: get_preferences not defined

@brmcdonald
Copy link
Owner

I will admit I haven't kept up with the newer versions of ArgParse, and I certainly understand the concern about having too many packages trying to do the same thing.

I've ended up using QuickArgParse as a dependency for other a number of other things (both PlasmaCNA and ichorCNA_U use it), so registering it would make installing those easier. This is the first package I've tried to register and I'm not familiar with the requirements for novelty, so if you think it's redundant and don't want to add to the package namespace that's fine.

The PlasmaCNA error is very odd. There is a Base.get_preferences apparently (last comment in JuliaLang/julia#41295), but I don't use it in PlasmaCNA, and I don't see a variable "get_preferences" anywhere in the source code. I will look into it more, thanks for the heads up.

@PallHaraldsson
Copy link
Author

redundant and don't want to add to the package namespace that's fine.

It's not really my say, and I don't know the rules. I was mainly thinking, if you actually didn't know of the alternatives. I didn't check your code to see if much (or full) overlap with others. Just found it likely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants