Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming suggestion for outputs of DetectDoublets #332

Open
ruochiz opened this issue Mar 16, 2023 · 0 comments
Open

Naming suggestion for outputs of DetectDoublets #332

ruochiz opened this issue Mar 16, 2023 · 0 comments

Comments

@ruochiz
Copy link

ruochiz commented Mar 16, 2023

Hi,

Thanks for developing and maintaining this awesome tool. I have one suggestion regarding the output of detectdoublets software, the naming of the column "doublet_pval" can be a bit confusing as it's not an actual p-value, but a probability score from 0-1, with higher value = more likely to be a doublet (based on the code and comments in the code). I would suggest changing it to sth like doublet_prob or doublet_probability_value.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant