[AN-146] Emit VM cost for GCP Batch #7582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucymcnatt
changed the title
.../batch/src/main/scala/cromwell/backend/google/batch/actors/BatchPollResultMonitorActor.scala
Show resolved
Hide resolved
|
putting it back in draft while I supply the vmInfo |
jgainerdewar
reviewed
Dec 4, 2024
|
|
||
| val allocationPolicy = AllocationPolicy | ||
| .newBuilder() | ||
| .setLocation(LocationPolicy.newBuilder().addAllowedLocations("regions/us-central1")) |
There was a problem hiding this comment.
I think it would be useful to have some tests checking how we handle unexpected location values - I'm nervous any time we're depending on Google not to change the way they generate a string.
There was a problem hiding this comment.
yeahhh makes sense, I can add another
...ch/src/test/scala/cromwell/backend/google/batch/actors/BatchPollResultMonitorActorSpec.scala
Show resolved
Hide resolved
lucymcnatt
commented
Dec 4, 2024
| @@ -627,7 +628,8 @@ object Dependencies { | |||
| "org.scalatest" %% "scalatest" % scalatestV, | |||
| // Use mockito Java DSL directly instead of the numerous and often hard to keep updated Scala DSLs. | |||
| // See also scaladoc in common.mock.MockSugar and that trait's various usages. | |||
| "org.mockito" % "mockito-core" % mockitoV | |||
| "org.mockito" % "mockito-core" % mockitoV, | |||
| "org.mockito" % "mockito-inline" % mockitoInlineV | |||
There was a problem hiding this comment.
necessary in order to mock a final method in the gcp BatchServiceClient
aednichols
approved these changes
Dec 6, 2024
jgainerdewar
approved these changes
Dec 9, 2024
.../batch/src/main/scala/cromwell/backend/google/batch/actors/BatchPollResultMonitorActor.scala
Outdated
Show resolved
Hide resolved
|
Approved pending test fixes and (probably?) removal of that log message. |
lucymcnatt
force-pushed
the
AN-146-batch-vm-cost
branch
2 times, most recently
from
e3c77f6 to
b4e437b
Compare
undo accidental delete fix another fix formatting remove extra log
lucymcnatt
force-pushed
the
AN-146-batch-vm-cost
branch
from
757ffae to
3134ed3
Compare
lucymcnatt
added a commit
that referenced
this pull request
Dec 9, 2024
This reverts commit 33cb56b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AN-146
Adds
BatchPollResultMonitorActor.extractVmInfoFromRunStateso that the /cost endpoint functions correctly for workflows run on GCP BatchRelease Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes