Added a check for whether files can be created and executed within th…

…e configured tmp-dir (#8951)

src/main/java/org/broadinstitute/hellbender/cmdline/CommandLineProgram.java

@@ -28,6 +28,7 @@
 import java.io.IOException;
 import java.net.InetAddress;
 import java.nio.file.*;
+import java.nio.file.attribute.PosixFilePermission;
 import java.text.DecimalFormat;
 import java.time.Duration;
 import java.time.ZonedDateTime;
@@ -167,6 +168,10 @@ public Object instanceMainPostParseArgs() {
         final Path p = tmpDir.toPath();
         try {
             p.getFileSystem().provider().checkAccess(p, AccessMode.READ, AccessMode.WRITE);
+
+            // Warn if there's anything that prevents execution in the tmp dir because some tools need that
+            tryToWriteAnExecutableFileAndWarnOnFailure(p);
+
             System.setProperty("java.io.tmpdir", IOUtils.getAbsolutePathWithoutFileProtocol(p));
         } catch (final AccessDeniedException | NoSuchFileException e) {
             // TODO: it may be that the program does not need a tmp dir
@@ -494,4 +499,49 @@ public final CommandLineParser getCommandLineParser() {
     protected interface AutoCloseableNoCheckedExceptions extends AutoCloseable{
         @Override void close();
     }
+
+    private void tryToWriteAnExecutableFileAndWarnOnFailure(final Path p) {
+        Path tempFilePath = null;
+        try {
+            // This test relies on the file system supporting posix file permissions
+            if(p.getFileSystem().supportedFileAttributeViews().contains("posix")) {
+                // Write an empty file to the tempdir
+                tempFilePath = Files.createTempFile(p, "gatk_exec_test", null);
+                // Add execute permissions
+                final Set<PosixFilePermission> executePermissions = EnumSet.of(
+                        PosixFilePermission.OWNER_EXECUTE,
+                        PosixFilePermission.GROUP_EXECUTE,
+                        PosixFilePermission.OTHERS_EXECUTE
+                );
+                final Set<PosixFilePermission> newPermissions = Files.getPosixFilePermissions(tempFilePath);
+                newPermissions.addAll(executePermissions);
+
+                Files.setPosixFilePermissions(tempFilePath, newPermissions);
+                if(!Files.isExecutable(tempFilePath)) {
+                    logger.warn(
+                        "User has permissions to create executable files within the configured temporary directory, " +
+                            "but cannot execute those files. It is possible the directory has been mounted using the " +
+                            "'noexec' flag. This can cause issues for some GATK tools. You can specify a different " +
+                            "directory using --tmp-dir"
+                    );
+                }
+            }
+        } catch(Exception e) {
+            logger.warn(
+                "Cannot create executable files within the configured temporary directory. It is possible " +
+                    "this user does not have the proper permissions to execute files within this directory. " +
+                    "This can cause issues for some GATK tools. You can specify a different directory using " +
+                    "--tmp-dir"
+            );
+            logger.debug(e);
+        } finally {
+            // Make sure we clean up the test file
+            try {
+                Files.deleteIfExists(tempFilePath);
+            } catch(Exception e) {
+                logger.warn("Failed to delete temp file for testing temp dir", e);
+            }
+        }
+
+    }
 }