[EchoCallset] Retry with more memory VCF extract [VS-1351] #8814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcovarr
requested review from
RoriCremer,
rsasch and
gbggrant
and removed request for
RoriCremer and
rsasch
mcovarr
force-pushed
the
vs_1351_retry_with_more_memory_vcf_extract_echo_callset
branch
from
910d7d3 to
88ebd90
Compare
mcovarr
changed the title
gbggrant
approved these changes
May 7, 2024
RoriCremer
reviewed
May 7, 2024
| exit 1 | ||
| fi | ||
|
|
||
| gatk --java-options "-Xmx${memory_mb}m" \ |
There was a problem hiding this comment.
oooooh i didn't know we could do this!
(can we do this all over the VAT pipeline too!??!?!)
There was a problem hiding this comment.
Sure why not. The hard part is remembering to tick the 'Retry with more memory' option when launching the workflow lol
There was a problem hiding this comment.
And we already need to remember to click on the reference disk checkbox for that...
RoriCremer
approved these changes
May 7, 2024
|
Intentionally failing test run here where I sabotaged the code to simulate an out of memory condition. You can see on the first attempt memory usage looks like after three retry-with-more-memory retries, things look like: |
mcovarr
deleted the
vs_1351_retry_with_more_memory_vcf_extract_echo_callset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.