Improved error messaging

• quote with ` • use mkString to avoid showing `List()`
broadinstitute · Apr 18, 2024 · 2c264ce · 2c264ce
1 parent a46b13b
commit 2c264ce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/scala/org/broadinstitute/gpp/poolq3/parser/BarcodeSet.scala b/src/main/scala/org/broadinstitute/gpp/poolq3/parser/BarcodeSet.scala
@@ -46,7 +46,7 @@ object BarcodeSet:
         .asScala
         .toList
         .map(_.trim)
-        .traverse(parseBarcode(s => InvalidFileException(file, s"Invalid DNA barcode '$s'")))
+        .traverse(parseBarcode(s => InvalidFileException(file, s"Invalid DNA barcode `$s`")))
         .map(bcs => new BarcodeSet(bcs.toSet))
         .flatTap(checkSet(file, _))
         .get // throws if an error was encountered

diff --git a/src/main/scala/org/broadinstitute/gpp/poolq3/parser/ReferenceData.scala b/src/main/scala/org/broadinstitute/gpp/poolq3/parser/ReferenceData.scala
@@ -93,11 +93,11 @@ object ReferenceData:
             // and reject cases where the barcode is empty but the ID is non-empty
             if barcode.isEmpty && id.isEmpty then None
             else if isReferenceBarcode(barcode) then Some(ReferenceEntry(barcode, id))
-            else throw InvalidFileException(file, s"Invalid DNA barcode '$barcode' for ID '$id'")
+            else throw InvalidFileException(file, s"Invalid DNA barcode '$barcode' for ID `$id`")
           case _ =>
             throw InvalidFileException(
               file,
-              s"Incorrect number of columns. At least 2 required, got: ${xs.length}: $xs"
+              s"Incorrect number of columns. At least 2 required, got: ${xs.length}: ${xs.mkString("`", "`, `", "`")}"
             )
       }