Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vendor data #27

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

erykpiast
Copy link
Contributor

The current version set doesn't include the latest Safari and iOS Safari versions. The last one recognised is 17.5, which was released in May 2024. This update brings Safari 18.1, released in October 2024.

@erykpiast
Copy link
Contributor Author

Let me know @g-plane if the way I'm doing the update is correct. I run it via git submodule update --remote --recursive and then I commit changes to the updated files. Does it make sense?

@g-plane
Copy link
Member

g-plane commented Feb 4, 2025

No, some repositories contain commits which not published to npm, so you should select tags.

@erykpiast erykpiast force-pushed the chore/update_versions branch from f3051eb to b773889 Compare February 6, 2025 01:17
@erykpiast
Copy link
Contributor Author

Is it any better now? I used the following command:

git submodule update --init --recursive
git submodule foreach 'git fetch --tags && git checkout $(git describe --tags `git rev-list --tags --max-count=1`)'

Copy link
Member

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"electron-to-chromium" should be 1.5.92. Everything else are OK.

@erykpiast erykpiast force-pushed the chore/update_versions branch from b773889 to 94b2383 Compare February 6, 2025 10:34
@erykpiast
Copy link
Contributor Author

Okay, I think they update as we speak. I've run the command now and it's 1.5.93 already. Changes pushed.

@g-plane g-plane merged commit cdd9741 into browserslist:main Feb 6, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants