Clickhouse: support both secure and non-secure connection #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turtleDev
reviewed
Jan 31, 2025
ingestr/src/destinations.py
Outdated
| @@ -302,9 +302,16 @@ def dlt_dest(self, uri: str, **kwargs): | |||
|
|
|||
| query_params = parse_qs(parsed_uri.query) | |||
| http_port = ( | |||
| int(query_params["http_port"][0]) if "http_port" in query_params else 8123 | |||
| int(query_params["http_port"][0]) if "http_port" in query_params else 8443 | |||
There was a problem hiding this comment.
We can set the default value by referencing secure.
If secure is 1 then 8443 else 8123.
turtleDev
approved these changes
Jan 31, 2025
sanjushahgupta
changed the title
karakanb
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.