Feature/introduce chess source #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karakanb
reviewed
Aug 19, 2024
docs/supported-sources/chess.md
Outdated
Comment on lines
23
to
25
| Chess requires a few steps to set up an integration, please follow the guide dltHub [has built here](https://dlthub.com/docs/dlt-ecosystem/verified-sources/chess#setup-guide). | ||
|
|
||
| Once you complete the guide, you should have a list of player usernames. Let's say your players are `max2 and peter23`; here's a sample command that will copy the data from Chess into a DuckDB database: |
There was a problem hiding this comment.
I don't think there are any integration steps for Chess.com, is there? I'd remove this bit.
sanjushahgupta
pushed a commit
that referenced
this pull request
Sep 4, 2024
Feature/introduce chess source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are made in this PR:
• added Chess as an source option in factory.py.
• added ChessSource class in source.py to fetch data from chess API
• added ingestr.src.chess in pyproject.toml