Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure inputs for actions #37

Merged
merged 43 commits into from
Jul 4, 2024
Merged
Show file tree
Hide file tree
Changes from 35 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
1d2dd5c
Document inputs in README
emcfarlane Jun 25, 2024
580d1ae
Drop public/private instance
emcfarlane Jun 28, 2024
bc82c27
Drop link to action.yaml
emcfarlane Jun 28, 2024
3784bf0
Reorder inputs to after defaults
emcfarlane Jun 28, 2024
cdcf1fc
Comment out github vars
emcfarlane Jun 28, 2024
063075d
Use BSR
emcfarlane Jun 28, 2024
77d06bd
Set pr_comment input
emcfarlane Jun 28, 2024
f18f782
Remove config options
emcfarlane Jun 28, 2024
325f207
Runs on Git PR
emcfarlane Jun 28, 2024
49dbce6
Config cleanup
emcfarlane Jun 28, 2024
cbc6acb
Remove generate step
emcfarlane Jun 28, 2024
3a7f519
Update push restriction docs
emcfarlane Jun 28, 2024
1abde1c
Add skip breaking example
emcfarlane Jun 28, 2024
0ef1fa1
Update CI
emcfarlane Jun 28, 2024
eff0b5e
Allow setting breaking_against
emcfarlane Jun 28, 2024
5d56822
Clarify breaking_against input settings
emcfarlane Jun 28, 2024
1ba8012
Improve example image
emcfarlane Jun 28, 2024
9b7ac8e
Improve breaking skip docs
emcfarlane Jun 28, 2024
d38f33c
Update disable skip example
emcfarlane Jun 28, 2024
02412e1
Sort inputs table
emcfarlane Jun 28, 2024
7681740
License and spell check
emcfarlane Jun 28, 2024
8a06b29
Fix test inputs
emcfarlane Jun 28, 2024
4dfa2c9
Natural language for default behaviour
emcfarlane Jun 28, 2024
ce6edb0
Drop unnamed test
emcfarlane Jun 28, 2024
6f82d37
Use BSR abbr
emcfarlane Jun 28, 2024
05387bf
Make default behaviour explicit
emcfarlane Jun 28, 2024
19e2fd0
Link to logging docs
emcfarlane Jun 28, 2024
a606be6
Update README.md
emcfarlane Jun 28, 2024
2ed82f7
Clarify label override docs
emcfarlane Jun 28, 2024
7f75f65
Update README.md
emcfarlane Jun 28, 2024
b9343f9
Show 2nd example
emcfarlane Jun 28, 2024
f55303e
Rename input->parameter
emcfarlane Jul 2, 2024
f9efb4d
Merge branch 'main' into ed/docInputs
emcfarlane Jul 2, 2024
fe735d2
precedence
nicksnyder Jul 2, 2024
52599a9
Cleanup debug
emcfarlane Jul 2, 2024
90ee766
Fix push disable create flag
emcfarlane Jul 2, 2024
f256831
Fix ordering
emcfarlane Jul 2, 2024
48f9380
Overwrite breaking_against subdir for input
emcfarlane Jul 2, 2024
d3cd98f
Fix docs
emcfarlane Jul 3, 2024
c7f1681
Include skipped checks in summary (#42)
emcfarlane Jul 3, 2024
aed803d
Merge branch 'main' into ed/docInputs
emcfarlane Jul 3, 2024
2c8213c
Bump deps
emcfarlane Jul 3, 2024
36b31b5
Update screenshot
emcfarlane Jul 3, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 12 additions & 53 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
breaking: false
push: false
archive: false
comment: false
pr_comment: false
test-format:
runs-on: ubuntu-latest
needs: build
Expand All @@ -112,7 +112,7 @@ jobs:
breaking: false
push: false
archive: false
comment: false
pr_comment: false
test-breaking:
runs-on: ubuntu-latest
needs: build
Expand All @@ -130,7 +130,7 @@ jobs:
breaking_against: .
push: false
archive: false
comment: false
pr_comment: false
test-comment:
runs-on: ubuntu-latest
if: github.event_name == 'pull_request'
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
breaking_against: .
push: false
archive: false
comment: true
pr_comment: true
- uses: actions/github-script@v7
with:
script: |
Expand Down Expand Up @@ -231,7 +231,7 @@ jobs:
breaking: false
push: true
archive: false
comment: false
pr_comment: false
test-push-token-only:
needs: build
runs-on: ubuntu-latest
Expand All @@ -252,7 +252,7 @@ jobs:
breaking: false
push: true
archive: false
comment: false
pr_comment: false
test-push-unnamed:
needs: build
runs-on: ubuntu-latest
Expand All @@ -272,7 +272,7 @@ jobs:
breaking: false
push: true
archive: false
comment: false
pr_comment: false
# Test v1 buf.yaml config.
- run: |
rm -rf proto
Expand All @@ -287,7 +287,7 @@ jobs:
breaking: false
push: true
archive: false
comment: false
pr_comment: false
input: proto
# Test v2 with multiple modules, one without a name.
- env:
Expand All @@ -306,7 +306,7 @@ jobs:
breaking: false
push: true
archive: false
comment: false
pr_comment: false
test-archive:
if: github.event_name == 'push' && github.ref_name != github.event.repository.default_branch
runs-on: ubuntu-latest
Expand All @@ -331,48 +331,7 @@ jobs:
breaking: false
push: false
archive: true
# On push github.ref_name, on delete github.event.ref_name.
archive_labels: ${{ github.ref_name }}
comment: false
test-archive-not-exists:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this as labels can no longer be given to the action.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on which merges first, I suppose it would affect #40, but that's okay :)

if: github.event_name == 'push'
runs-on: ubuntu-latest
needs:
- test-push
- test-push-token-only
- test-push-unnamed
steps:
- uses: actions/checkout@v4
- env:
BUF_USERNAME: ${{ secrets.BUF_USERNAME }}
run: |
mkdir -p proto/foo/v1
printf "version: v2\nmodules:\n - path: proto\n name: ${BUF_MODULE}\n" > buf.yaml
printf "syntax = \"proto3\";\npackage foo.v1;\nmessage Bar {}\n" > proto/foo/v1/bar.proto
- uses: ./
with:
username: ${{ secrets.BUF_USERNAME }}
token: ${{ secrets.BUF_TOKEN }}
lint: false
format: false
breaking: false
push: false
archive: true
archive_labels: label_does_not_exist
comment: false
- uses: ./
with:
username: ${{ secrets.BUF_USERNAME }}
token: ${{ secrets.BUF_TOKEN }}
lint: false
format: false
breaking: false
push: false
archive: true
archive_labels: |
label_does_not_exist
label_does_not_exist_either
comment: false
pr_comment: false
test-archive-unnamed:
if: github.event_name == 'push'
runs-on: ubuntu-latest
Expand All @@ -394,7 +353,7 @@ jobs:
breaking: false
push: false
archive: true
comment: false
pr_comment: false
- run: |
rm -rf proto
mkdir -p proto/foo/v1
Expand All @@ -408,5 +367,5 @@ jobs:
breaking: false
push: false
archive: true
comment: false
pr_comment: false
input: proto
Loading
Loading