Skip to content

Commit

Permalink
code comment
Browse files Browse the repository at this point in the history
  • Loading branch information
mfridman committed Dec 5, 2024
1 parent 86ec011 commit f2ad326
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -277,13 +277,14 @@ func newGoRegistryConfig(
},
)
}
// If a base plugin name is specified, it must also exist in the top-level plugin deps list.
// If a base plugin name is specified, it must also exist in the top-level plugin dependencies
// list.
var basePluginIdentity bufremotepluginref.PluginIdentity
if externalGoRegistryConfig.BasePluginName != "" {
var err error
basePluginIdentity, err = pluginIdentityForStringWithOverrideRemote(externalGoRegistryConfig.BasePluginName, overrideRemote)
if err != nil {
return nil, err
return nil, fmt.Errorf("failed to parse base plugin: %w", err)
}
ok := slices.ContainsFunc(pluginDependencies, func(ref bufremotepluginref.PluginReference) bool {
return ref.IdentityString() == basePluginIdentity.IdentityString()
Expand Down

0 comments on commit f2ad326

Please sign in to comment.