Update user_id to reserved in UserPluginPreferences
#2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bufdev
reviewed
Apr 16, 2024
gilwong00
changed the title
user_id from UserPluginPreferences user_id to reserved from UserPluginPreferences
gilwong00
changed the title
user_id to reserved from UserPluginPreferences user_id to reserved in UserPluginPreferences
fyockm
reviewed
Apr 16, 2024
mfridman
reviewed
Apr 16, 2024
| @@ -59,8 +59,7 @@ message OrganizationUser { | |||
| // These preferences are stored in the database so the language and plugins | |||
| // are pre-selected when the user navigates back to the Generated SDKs page from any device or browser. | |||
| message UserPluginPreference { | |||
| // The id of the user. | |||
| string user_id = 1; | |||
| reserved 1; | |||
There was a problem hiding this comment.
We should probably be consistent and reserve both field number and name. E.g.,
buf/proto/buf/alpha/registry/v1alpha1/organization.proto
Lines 234 to 235 in 0b24de2
buf/proto/buf/alpha/registry/v1alpha1/module.proto
Lines 33 to 34 in 0b24de2
There was a problem hiding this comment.
got it, updated in the latest commit.
bufdev
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
user_idfromUserPluginPreferencesmessage andGetUserPluginPreferencesRequestmessage. We can infer the user id from the cookie so cleaning up our request payload and response.