Update protovalidate dependency #3652
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
|
Seems like we are running into problems with the latest protobuf runtime. |
This should be resolved on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a successor to #3610.
Changed:
WithFilterThis uses an unreleased version of protovalidate-go, which was suggested so we could try to finalize the filter API before cutting a release with it.
Open question remains: should we try to warn users if the legacy removed protovalidate options are present, somehow? I assume this could be checked by looking for unknown fields in the options.
(This should unbreak the errors that occur when trying to use buf with
go tool, although we do not recommend usinggo tool.)