Add toolchain to go.mod overrides #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
commented
Aug 19, 2024
| @@ -20,6 +20,8 @@ GO_GET_PKGS ?= | |||
| # Settable | |||
| GO_MOD_VERSION ?= 1.21 | |||
| # Settable | |||
| GO_MOD_TOOLCHAIN ?= 1.23.0 | |||
There was a problem hiding this comment.
We could set +auto to allow higher versions? https://go.dev/doc/toolchain
There was a problem hiding this comment.
Let's do this for now and then change it later if we want
emcfarlane
commented
Aug 19, 2024
| @@ -70,6 +72,7 @@ upgradegodeps: | |||
| rm -f go.mod go.sum | |||
| go mod init $(GO_MODULE) | |||
| go mod edit -go=$(GO_MOD_VERSION) | |||
| go mod edit -toolchain=go$(GO_MOD_TOOLCHAIN) | |||
There was a problem hiding this comment.
Suggested change
| go mod edit -toolchain=go$(GO_MOD_TOOLCHAIN) | |
| go mod edit -toolchain=go$(GO_MOD_TOOLCHAIN)+auto |
bufdev
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the toolchain is set. Issue from bufbuild/buf#3251 where upgrade drops the toolchain value.