Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade google.golang.org/protobuf/proto and buf to latest #153

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

mfridman
Copy link
Member

This PR bumps the following deps to their latest versions:

  • buf -> v1.41.0
  • google.golang.org/protobuf/proto -> v1.34.3-0.20240906163944-03df6c145d96

The bufbuild/buf repository depends on a non-released version, which leads to conflicting versions due to makego's pin. For example,

go get  github.com/bufbuild/buf@main google.golang.org/[email protected] google.golang.org/protobuf/[email protected] connectrpc.com/[email protected]
go: for module google.golang.org/protobuf, google.golang.org/protobuf/[email protected] conflicts with google.golang.org/[email protected]
make: *** [upgradegodeps] Error 1

Copy link
Member

@bufdev bufdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for reviews on makego for rep updates

@mfridman mfridman merged commit 37b7939 into main Sep 16, 2024
3 checks passed
@mfridman mfridman deleted the mf/bump-deps branch September 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants