Skip to content

Commit

Permalink
Bump protocolbuffers/[email protected] to netstandard2.0 (#1592)
Browse files Browse the repository at this point in the history
.NET 9 SDK
[raises](https://learn.microsoft.com/en-ca/dotnet/core/compatibility/sdk/9.0/netstandard-warning)
a (suppressable) build warning about this, largely to encourage
developers to upgrade. This should not be an issue for consumers, as the
more important consideration is the hosting application's target
framework.

More importantly, using `netstandard1.1` results in a vulnerable version
of `System.Net.Http` being pulled in (`4.3.0`) via `Google.Protobuf`'s
`netstandard1.1` deps. Upgrading to `netstandard2.0` resolves this.

`grpc/csharp` is already using `netstandard2.0`. No other C# plugins
exist.
  • Loading branch information
saquibmian authored Nov 15, 2024
1 parent cbde03f commit b6688fa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion plugins/protocolbuffers/csharp/v28.3/buf.plugin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ registry:
- base_namespace=
nuget:
target_frameworks:
- netstandard1.1
- netstandard2.0
deps:
- name: Google.Protobuf
version: 3.28.3
2 changes: 1 addition & 1 deletion plugins/protocolbuffers/csharp/v28.3/build.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard1.1</TargetFramework>
<TargetFramework>netstandard2.0</TargetFramework>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Google.Protobuf" Version="3.28.3" />
Expand Down

0 comments on commit b6688fa

Please sign in to comment.