Improve ts/duration and handling of UPPER acronyms #4
Conversation
| ) | ||
|
|
||
| func Version() string { |
There was a problem hiding this comment.
We don't want to do this - we want the version to be static and part of the build, same as our other OSS repos. Also no Godoc
@mfridman just spent a good amount of time getting this OSS-ready, check in with him before merging
There was a problem hiding this comment.
I think pre-Go modules the 2-step commit made sense. But with Go modules and >=go1.12+ this has become the most ergonomic way to handle versioning.
Maybe it would be worth chatting internally if this can be an acceptable way of propagating a version?
EDIT: one of the advantages of reading the BuildInfo is the go toolchain synthesizes the pseudo-version, so if you do something like go install ... @main it'll give you the exact VCS info like commit time/hash.
There was a problem hiding this comment.
Got it - let's chat Monday you me @Alfus and make sure we're on same page - if this is the way forward, I'd want to start making it the OSS standard across our repos (can convert over time)
There was a problem hiding this comment.
One of the things is id worry what this means for ie dev builds, but yea lets chat Monday
No description provided.