Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against specific Go version #311

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Test against specific Go version #311

merged 1 commit into from
Feb 14, 2025

Conversation

nicksnyder
Copy link
Member

@nicksnyder nicksnyder commented Feb 14, 2025

Two reasons for this:

  • We should explicitly tests against the minimum Go version we advertise
  • The version of Go needs to be updated in lockstep with the version of golangci-lint to avoid build errors.

The build started failing for new commits because Go 1.24 was release and started getting used in CI build, but we were pinned to an older golangci-lint.

@nicksnyder nicksnyder requested a review from rodaine February 14, 2025 00:10
Copy link

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedFeb 14, 2025, 12:10 AM

@nicksnyder nicksnyder merged commit ee50178 into main Feb 14, 2025
8 checks passed
@nicksnyder nicksnyder deleted the fix-ci branch February 14, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants