Add tests for IGNORE_ALWAYS #322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
timostamm
added
the
Conformance
rodaine
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
FieldConstraints.ignore = IGNORE_ALWAYS, the validation rules of a field will be skipped and not evaluated.This PR adds 140 tests to ensure that rules are skipped. The new tests follow the pattern of the existing tests for IGNORE_IF_UNPOPULATED and the other ignore options.
Same as the existing tests, the new tests do not cover that custom field constraints or nested constraints (a field referencing a message that has field constraints) are skipped. We may want to extend the coverage in a follow-up.