Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repository_url to reproducible attributes #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add repository_url to reproducible attributes #94

wants to merge 1 commit into from

Conversation

styurin
Copy link

@styurin styurin commented Jan 10, 2025

When repository_url is used, bazel complains about reproducible form:

DEBUG: Rule 'rules_buf_toolchains' indicated that a canonical reproducible form can be obtained by dropping arguments ["repository_url"]

repository_url should be included in the attributes returned from the rule to indicate that it can also be used to generate reproducible form.

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@styurin styurin marked this pull request as ready for review January 10, 2025 17:48
@styurin
Copy link
Author

styurin commented Jan 10, 2025

@srikrsna-buf please, take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@styurin @CLAassistant