✨ Add metrics endpoint #389
Conversation
pajowu
force-pushed
the
pajowu/metrics_api
branch
from
26c441f to
08b567d
Compare
pajowu
force-pushed
the
pajowu/metrics_api
branch
4 times, most recently
from
8bed38d to
0472589
Compare
| pass | ||
|
|
||
|
|
||
| class TasksInState(Metric): |
There was a problem hiding this comment.
I would rather like to have this as TaskChanis or TaskGraphs in state. Otherwise this number is not really saying much (Transcode is much faster, yadayada)
There was a problem hiding this comment.
I think the nicer way would be to have the task type as a label as well, I'll change that
There was a problem hiding this comment.
I would prefer some other task parameters (that influence needed computing time) as labels then too
|
|
||
| class Queue(Metric): | ||
| def __init__(self): | ||
| self.collector = Gauge("queue", "Queue length in seconds") |
There was a problem hiding this comment.
Same here. I would like to have every task chain only counted once
There was a problem hiding this comment.
Or maybe we introduce some unit here that is not seconds (maybe something like estimated compute seconds on some specific platform? the mac mini?)
There was a problem hiding this comment.
Yes and no. Doing a better calculation that takes into account the real time factor of different machines etc would be a nice addition, but I'd rather do that in a seperate PR, as this has some more open questions to me (and probably needs some database changes as well)
There was a problem hiding this comment.
Then for the time being only count transcription tasks?
pajowu
force-pushed
the
pajowu/metrics_api
branch
from
82b6463 to
8db05ec
Compare
No description provided.