Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Switch to faster-whisper #397

Merged
merged 1 commit into from
Dec 2, 2023
Merged

⚡️ Switch to faster-whisper #397

merged 1 commit into from
Dec 2, 2023

Conversation

pajowu
Copy link
Member

@pajowu pajowu commented Nov 30, 2023

This also disables the alignment task, because faster-whisper can give
proper word-timestamps. It also simplifies the code a bit, as
faster-whisper already contains logic to re-combine words from the
tokens etc.

@pajowu pajowu requested review from anuejn, phlmn and rroohhh November 30, 2023 14:28
@pajowu pajowu force-pushed the pajowu/faster_whisper branch 3 times, most recently from 44f7332 to 01cf079 Compare November 30, 2023 14:53
@pajowu pajowu enabled auto-merge November 30, 2023 15:08
Copy link
Member

@anuejn anuejn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, only minor nits

worker/tests/test_transcribe.py Outdated Show resolved Hide resolved
worker/transcribee_worker/worker.py Outdated Show resolved Hide resolved
This also disables the alignment task, because faster-whisper can give
proper word-timestamps. It also simplifies the code a bit, as
faster-whisper already contains logic to re-combine words from the
tokens etc.
@pajowu pajowu force-pushed the pajowu/faster_whisper branch from 01cf079 to b55e9a3 Compare December 2, 2023 19:14
@pajowu pajowu added this pull request to the merge queue Dec 2, 2023
Merged via the queue into main with commit c81003d Dec 2, 2023
2 checks passed
@pajowu pajowu deleted the pajowu/faster_whisper branch December 2, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants