Fix for event permissions returning false in iOS17+ #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasEventPermissions check ios17/18
EventStoreManager.shared.eventStore
|
looking at the failing test, the fix requires iOS 13.0 or later. Anyone wanting to share their thoughts on the topic? |
|
Ah sorry, I'm targetting iOS 15 in my app indeed. As far as I know all iPhones that supported iOS 13 also support iOS 14 and 15 so I'd say it's probably safe to drop support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix error when checking for permissions in iOS17/iOS18
Related bug: #561
Reference: https://forums.developer.apple.com/forums/thread/739315