Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): next #1649

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(): next #1649

wants to merge 1 commit into from

Conversation

dvoegelin
Copy link
Collaborator

Description

feat(NovoDataTablePagination): Add option to show the total number of records in a table next to pagination #1648

Verify that...

  • Any related demos were added and npm start and npm run build still works
  • New demos work in Safari, Chrome and Firefox
  • npm run lint passes
  • npm test passes and code coverage is increased
  • npm run build still works

Bullhorn Internal Developers

  • Run Novo Automation
Screenshots

#1648)

* feat(NovoDataTablePagination): Add option to show the total number of records in a table next to pagination

* feat(NovoDataTablePagination): Update to always show total in pagination when in footer

* Updating logic to not show if total is null or undefined

* Update check to see if pagination is loading
@dvoegelin dvoegelin self-assigned this Jan 31, 2025
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 87f65d7):

https://novo-elements--pr1649-next-tryzkwow.web.app

(expires Fri, 07 Feb 2025 15:14:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f1783e19c2444272095017dd8ba433fff0ee3f61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants