Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#155 process is undefined in webpack #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seveves
Copy link

@seveves seveves commented Apr 21, 2017

process is a global nodejs variable that is not defined in the browser by default. So webpack doesn't know about it. Of course there are ways to define the process variable with webpack but that is not the default behavior and needs a plugin (DefinePlugin) or other workaround.
I've tested this change locally with an angular/ionic app and it works great. I also tried to keep the ternary operator (?:) but this also confuses webpack.

process is a global nodejs variable that is not defined in the browser by default. So webpack doesn't know about it. Of course there are ways to define the process variable with webpack but that is not the default behavior and needs a plugin (DefinePlugin) or other workaround.
I've tested this change locally with an angular/ionic app and it works great.
@seveves
Copy link
Author

seveves commented Apr 21, 2017

PR #189 will be fixed with this too

@seveves seveves mentioned this pull request Apr 21, 2017
niftylettuce added a commit to breejs/later that referenced this pull request Aug 17, 2020
@niftylettuce
Copy link

This issue is now fixed per my work with Bree, I have an updated fork of this package called @breejs/later. See https://github.com/breejs/later if you have additional PR's or issues to file. Contributions welcome to clean it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants