Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade dependencies and fix compilation error following the upgrade #529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: upgrade dependencies and fix compilation error following the upgrade #529

wants to merge 1 commit into from

Conversation

RouxAntoine
Copy link

when I upgrade my build compute to node 22 I have this error:

--> pnpm install --frozen-lockfile
Lockfile is up to date, resolution step is skipped
Packages: +996
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 996, reused 996, downloaded 0, added 0, done
node_modules/.pnpm/[email protected]/node_modules/node-pty: Running install script, failed in 71ms
.../node_modules/node-pty install$ node scripts/install.js
│ node:events:498
│       throw er; // Unhandled 'error' event
│       ^
│ Error: spawn node-gyp ENOENT
│     at ChildProcess._handle.onexit (node:internal/child_process:286:19)
│     at onErrorNT (node:internal/child_process:484:16)
│     at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
│ Emitted 'error' event on ChildProcess instance at:
│     at ChildProcess._handle.onexit (node:internal/child_process:292:12)
│     at onErrorNT (node:internal/child_process:484:16)
│     at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
│   errno: -2,
│   code: 'ENOENT',
│   syscall: 'spawn node-gyp',
│   path: 'node-gyp',
│   spawnargs: [ 'rebuild' ]
│ }
│ Node.js v22.3.0
└─ Failed in 71ms at /Users/antoine/Documents/virtualization/containers/docker-wetty/wetty/node_modules/.pnpm/[email protected]/node_modules/node-pty
node_modules/.pnpm/[email protected]/node_modules/esbuild: Running postinstall script...
node_modules/.pnpm/[email protected]/node_modules/bufferutil: Running install script...
node_modules/.pnpm/[email protected]/node_modules/husky: Running install script...
node_modules/.pnpm/[email protected]/node_modules/gc-stats: Running install script...
 ELIFECYCLE  Command failed with exit code 1.
node_modules/.pnpm/[email protected]/node_modules/utf-8-validate: Running install script...

--> node --version
v22.3.0

So this pull request upgrade the dependencies and fix build error with new version in login.ts and spawn.ts.

@RouxAntoine
chore: upgrade dependencies and fix compilation error
b9e9272 
this upgrade are possibly need for node v22
RouxAntoine
RouxAntoine commented Jun 22, 2024
View reviewed changes
src/server/login.ts
socket.emit('data', data);
});
socket
.on('input', (input: string) => {
term.write(input);
buf = /\177/.exec(input) ? buf.slice(0, -1) : buf + input;
buf = /\\177/.exec(input) ? buf.slice(0, -1) : buf + input;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this change, but with the original /\177/ I have this error:

[23:08:48] [tsc] Command exited with error code: Error: Command failed with exit code 2: tsc -p tsconfig.node.json
src/server/login.ts(28,17): error TS1534: This backreference refers to a group that does not exist. There are no capturing groups in this regular expression.
 ELIFECYCLE  Command failed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RouxAntoine