Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rust-cache with proper key and global RUSTFLAG #764

Merged
merged 14 commits into from
Dec 8, 2023
Merged

fix rust-cache with proper key and global RUSTFLAG #764

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4fa9d6c
feat: use github actions cache with proper key
swanandx Dec 7, 2023
e23c07b
trigger the workflow
swanandx Dec 7, 2023
63a1f26
retrigger workflow and hope cache works
swanandx Dec 7, 2023
9081208
plz retrigger workflow and hope cache works
swanandx Dec 7, 2023
27a5165
try rust-cache to see if helps
swanandx Dec 7, 2023
eb39788
retrigger workflow just to check hash
swanandx Dec 7, 2023
609450f
using shared-key should turn off automatic job-id hashes
swanandx Dec 7, 2023
b79c8a5
did it helped?
swanandx Dec 7, 2023
3febe08
why workflow not using cached data even if we restore it
swanandx Dec 7, 2023
80ddbdc
changing RUSTFLAGS causes rebuild of project!
swanandx Dec 7, 2023
836eedf
moment of truth
swanandx Dec 7, 2023
e8607ab
is this really moment of truth?
swanandx Dec 7, 2023
72ff92b
the real final moment of truth
swanandx Dec 7, 2023
b982588
now i can sleep peacefully
swanandx Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ on:

name: Build and Test

env:
RUSTFLAGS: "-D warnings"

jobs:
test:
name: Build and test on ${{ matrix.os }} with ${{ matrix.features }}
Expand All @@ -29,6 +32,8 @@ jobs:
components: clippy

- uses: Swatinem/rust-cache@v2
with:
shared-key: ${{ runner.os }}-cargo

- uses: taiki-e/install-action@v1
with:
Expand All @@ -46,8 +51,6 @@ jobs:

- name: Check rumqttc and rumqttd
run: cargo hack clippy --verbose --each-feature --no-dev-deps --optional-deps url -p rumqttc -p rumqttd
env:
RUSTFLAGS: "-D warnings"

- name: Check docs
if: ${{ matrix.os != 'windows-latest' }}
Expand Down