Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make external_auth pub available again. #879

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

silvestrpredko
Copy link
Contributor

@silvestrpredko silvestrpredko commented Jun 13, 2024

Type of change

Miscellaneous (related to maintenance): Allow creation of ConnectionSettings

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

Copy link
Member

@swanandx swanandx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! :)

@swanandx swanandx merged commit 0767080 into bytebeamio:main Jun 13, 2024
4 checks passed
@coveralls
Copy link

coveralls commented Jun 13, 2024

Pull Request Test Coverage Report for Build 9501562304

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix-connection-settings at 36.131%

Totals Coverage Status
Change from base Build 9451919087: 36.1%
Covered Lines: 5970
Relevant Lines: 16523

💛 - Coveralls

@silvestrpredko silvestrpredko deleted the fix-connection-settings branch June 13, 2024 14:53
silvestrpredko added a commit to inomotech-foss/rumqtt that referenced this pull request Jun 14, 2024
silvestrpredko added a commit to inomotech-foss/rumqtt that referenced this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants