fix: allow empty genepanel query for API #11358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The branch doesn't build https://github.com/cBioPortal/cbioportal/actions/runs/13027890996/job/36679514058?pr=11358 |
|
Fixed, thans for the notification, accidentally removed a line with the variable definition. |
oplantalech
approved these changes
Feb 5, 2025
inodb
force-pushed
the
fix/gene-panels-api
branch
from
ca43fca to
cd66b71
Compare
haynescd
reviewed
Feb 7, 2025
| List<SampleMolecularIdentifier> molecularSampleIdentifier = interceptedGenePanelDataMultipleStudyFilter.getSampleMolecularIdentifiers(); | ||
|
|
||
| if (molecularSampleIdentifier == null) { | ||
| return new ResponseEntity<>(new ArrayList<GenePanelData>(), HttpStatus.OK); |
There was a problem hiding this comment.
This can be simplified to ResponseEntity.ok(List.of())
|
Looks good left one comment and you just need to fix the conflicts. We have started updating the project structure and moved all the old code under a legacy folder. Let me know if you need help fixing the conflicts |
Aiosa
force-pushed
the
fix/gene-panels-api
branch
from
cd66b71 to
0e9a4cc
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11252
Describe changes proposed in this pull request:
Gene panel queries can be empty if a study does not have gene panel data.