Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use search on Android 15 #206

Open
1 of 4 tasks
gadgetguy08 opened this issue Oct 24, 2024 · 3 comments
Open
1 of 4 tasks

Unable to use search on Android 15 #206

gadgetguy08 opened this issue Oct 24, 2024 · 3 comments
Labels

Comments

@gadgetguy08
Copy link

gadgetguy08 commented Oct 24, 2024

Required before filing an issue:

I am a:

  • Real user of Poet Assistant
  • Student or researcher
  • Reporting an issue found by a software analysis or automation tool
  • Other: Please explain

Latest version (1.30.8) displays the search icon on top of the screen in the notification area (with battery level, network strength, etc.) and is unusable on Android 15 Graphene OS. Note this occurs in portrait mode only. Landscape mode works.

@caarmen
Copy link
Owner

caarmen commented Oct 26, 2024

Thanks for bringing this to my attention.

I indeed do see a difference between 1.30.7 and 1.30.8.

1.30.7 1.30.8
image image

These screenshots are from a Google emulator, using Android 15, Default Android System Image. it's the closest I could get to Graphene OS 😅

On the emulator, the search icon is still clickable. But I can indeed see that it's higher up than the previous release.

I'll put updates here as I find more info about this change, or when there's a fix!

@caarmen
Copy link
Owner

caarmen commented Oct 26, 2024

This regression was introduced in b7522fa

Looks like the bug doesn't occur on Android 14.

Also: rolling back targetSdkVersion to 34 removes the regression, on Android 15. (Not saying that's a solution.)

We may be hitting this behavior change, when targeting Android 15, regarding insets: https://developer.android.com/about/versions/15/behavior-changes-15#edge-to-edge

@caarmen caarmen added the bug label Oct 26, 2024
caarmen added a commit that referenced this issue Oct 26, 2024
We're hitting this behavior change when targeting Android 15: https://developer.android.com/about/versions/15/behavior-changes-15#not-edge-to-edge

The documentation says:
> you need to add android:fitsSystemWindows="true" if using AppBarLayout.
caarmen added a commit that referenced this issue Oct 26, 2024
We're hitting this behavior change when targeting Android 15: https://developer.android.com/about/versions/15/behavior-changes-15#not-edge-to-edge

The documentation says:
> you need to add android:fitsSystemWindows="true" if using AppBarLayout.

Also apply a code snippet to various views: to ensure that the top and bottom aren't hidden under the system bars.
caarmen added a commit that referenced this issue Oct 27, 2024
We're hitting this behavior change when targeting Android 15: https://developer.android.com/about/versions/15/behavior-changes-15#not-edge-to-edge

The documentation says:
> you need to add android:fitsSystemWindows="true" if using AppBarLayout.

Also apply a code snippet to various views: to ensure that the top and bottom aren't hidden under the system bars.
caarmen added a commit that referenced this issue Oct 27, 2024
Issue #206: Fix broken insets since targeting Android 15.
@caarmen
Copy link
Owner

caarmen commented Oct 27, 2024

Thanks again for reporting this, and being on the bleeding edge with the latest Android version 😁

Release 1.30.9 (#208) fixes a few related things:

  • The search icon being mixed with the status bar items.
  • The last items of a long list being unclickable under the navigation bar.
  • The content at the top of the settings and about screens being unclickable under the status bar.

However, after pushing this release, I realized that there's still at least one remaining issue: in landscape mode, if you have a navigation bar (you're not using gesture navigation), the overflow menu (the three dots) is unclickable, under the navigation bar:

image

This is addressed in #209 and will be in release-1.30.10.

caarmen added a commit that referenced this issue Oct 27, 2024
The previous approach assumed we'd need similar inset adjustments to the root view, in all screens.

Each screen is a bit different. Adjust the padding/margins of views per the insets, for each screen accordingly.
caarmen added a commit that referenced this issue Oct 27, 2024
The previous approach assumed we'd need similar inset adjustments to the root view, in all screens.

Each screen is a bit different. Adjust the padding/margins of views per the insets, for each screen accordingly.
caarmen added a commit that referenced this issue Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants